Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix OCIS_RUN_SERVICES #4133

Merged
merged 1 commit into from
Jul 7, 2022
Merged

fix OCIS_RUN_SERVICES #4133

merged 1 commit into from
Jul 7, 2022

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented Jul 7, 2022

Description

OCIS_RUN_SERVICES was introduced as successor to OCIS_RUN_EXTENSIONS because
we wanted to call oCIS "core" extensions services. We kept OCIS_RUN_EXTENSIONS for
backwards compatibility reasons.

It turned out, that setting OCIS_RUN_SERVICES has no effect since introduced. OCIS_RUN_EXTENSIONS.
OCIS_RUN_EXTENSIONS was working fine all the time.

We now fixed OCIS_RUN_SERVICES, so that you can use it as a equivalent replacement for OCIS_RUN_EXTENSIONS

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

kobergj
kobergj approved these changes Jul 7, 2022
View reviewed changes
Copy link
Collaborator

@kobergj kobergj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Fix 👍

dragonchaser
dragonchaser approved these changes Jul 7, 2022
View reviewed changes
Copy link
Member

@dragonchaser dragonchaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ownclouders
Copy link
Contributor

ownclouders commented Jul 7, 2022 •
edited
Loading

💥 Acceptance test Core-API-Tests-ocis-storage-10 failed. Further test are cancelled...

@sonarcloud
Copy link

sonarcloud bot commented Jul 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@owncloud owncloud deleted a comment from update-docs bot Jul 7, 2022
@phil-davis phil-davis merged commit bcdbaa1 into owncloud:master Jul 7, 2022
ownclouders pushed a commit that referenced this pull request Jul 7, 2022
@phil-davis
commit bcdbaa1
851c519 
Merge: af1a29d ab960dc
Author: Phil Davis <phil@jankaritech.com>
Date:   Thu Jul 7 20:33:01 2022 +0545

    Merge pull request #4133 from wkloucek/fix-ocis-run-services

    fix `OCIS_RUN_SERVICES`
@wkloucek wkloucek deleted the fix-ocis-run-services branch July 8, 2022 05:24
This was referenced Jul 9, 2022
Merged
Closed
@micbar micbar mentioned this pull request Jul 19, 2022
Closed
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhafer rhafer rhafer approved these changes

@dragonchaser dragonchaser dragonchaser approved these changes

@kobergj kobergj kobergj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@wkloucek @ownclouders @rhafer @dragonchaser @kobergj @phil-davis